Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove specialist topic code #2068

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Remove specialist topic code #2068

merged 1 commit into from
Feb 21, 2024

Conversation

georges1996
Copy link
Contributor

@georges1996 georges1996 commented Feb 18, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

Ticket: https://trello.com/c/f6QxCh5o/2380-remove-specialist-topic-code-from-publisher-m

What

Publisher is an app used by internal gov.uk content designers to publish mainstream content to GOV.UK. You can access the Publisher UI via signon. Publisher supports tagging content to Specialist topics. As we are retiring specialist topics, we need to remove the the specialist topic tagging form from the tagging UI, as well as clear up any associated code.

Why

To prevent old code hanging around leading to bugs and confusion. Ie if we don’t tidy up we will be leave a big pile of tech debt.

When

This card can be picked up now. It is not dependent on completing the epic to retire all specialist topics.

@georges1996 georges1996 force-pushed the remove-spec-topic branch 5 times, most recently from 109aae5 to 385fa70 Compare February 19, 2024 12:10
@georges1996 georges1996 marked this pull request as ready for review February 19, 2024 12:19
@georges1996 georges1996 force-pushed the remove-spec-topic branch 2 times, most recently from b598c6b to 309cdee Compare February 20, 2024 09:28
Copy link
Contributor

@Tetrino Tetrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georges1996 georges1996 force-pushed the remove-spec-topic branch 2 times, most recently from 90eca8d to 28f9fa4 Compare February 20, 2024 13:54
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks George, this is looking good, but you've missed a few :-) https://github.com/search?q=repo%3Aalphagov%2Fpublisher%20topics&type=code

@georges1996 georges1996 merged commit 8e71099 into main Feb 21, 2024
13 checks passed
@georges1996 georges1996 deleted the remove-spec-topic branch February 21, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants